From 9ecd5ff3a5c4d3f21aecdebfff1e5253be907461 Mon Sep 17 00:00:00 2001 From: Antoine Aflalo <197810+Belphemur@users.noreply.github.com> Date: Wed, 28 Aug 2024 11:53:26 -0400 Subject: [PATCH] fix(webp): fix the actual maximum limit --- converter/converter_test.go | 7 ++++++- converter/webp/webp_converter.go | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/converter/converter_test.go b/converter/converter_test.go index 9429260..e3b18fe 100644 --- a/converter/converter_test.go +++ b/converter/converter_test.go @@ -21,6 +21,11 @@ func TestConvertChapter(t *testing.T) { genTestChapter: genBigPages, split: true, }, + { + name: "Big Pages, no split", + genTestChapter: genBigPages, + split: false, + }, { name: "No split pages", genTestChapter: genSmallPages, @@ -87,7 +92,7 @@ func genBigPages(path string) (*manga.Chapter, error) { var pages []*manga.Page for i := 0; i < 5; i++ { // Assuming there are 5 pages for the test - img := image.NewRGBA(image.Rect(0, 0, 300, 10000)) + img := image.NewRGBA(image.Rect(0, 0, 300, 17000)) buf := new(bytes.Buffer) err := jpeg.Encode(buf, img, nil) if err != nil { diff --git a/converter/webp/webp_converter.go b/converter/webp/webp_converter.go index f89c2cd..402b880 100644 --- a/converter/webp/webp_converter.go +++ b/converter/webp/webp_converter.go @@ -204,8 +204,8 @@ func (converter *Converter) checkPageNeedsSplit(page *manga.Page) (bool, image.I bounds := img.Bounds() height := bounds.Dy() - if height >= converter.maxHeight { - return false, img, format, fmt.Errorf("page[%d] height %d exceeds maximum height %d of webp format", page.Index, height, converter.maxHeight) + if height >= webpMaxHeight { + return false, img, format, fmt.Errorf("page[%d] height %d exceeds maximum height %d of webp format", page.Index, height, webpMaxHeight) } return height >= converter.maxHeight, img, format, nil }