fix: Keep page as they are if we can't decode them and disable conversion

This commit is contained in:
Antoine Aflalo
2025-09-03 22:15:10 -04:00
parent a151a1d4f8
commit ede8d62572
3 changed files with 17 additions and 29 deletions

View File

@@ -171,21 +171,15 @@ func (converter *Converter) ConvertChapter(ctx context.Context, chapter *manga.C
var pageIgnoredError *converterrors.PageIgnoredError
if errors.As(err, &pageIgnoredError) {
log.Info().Err(err).Msg("Page ignored due to image decode error")
} else {
select {
case errChan <- err:
case <-ctx.Done():
return
}
}
if img != nil {
wgConvertedPages.Add(1)
select {
case pagesChan <- manga.NewContainer(page, img, format, false):
case <-ctx.Done():
return
}
wgConvertedPages.Add(1)
select {
case pagesChan <- manga.NewContainer(page, img, format, false):
case <-ctx.Done():
return
}
return
}
@@ -264,6 +258,7 @@ func (converter *Converter) ConvertChapter(ctx context.Context, chapter *manga.C
log.Debug().
Str("chapter", chapter.FilePath).
Int("error_count", len(errList)).
Err(errors.Join(errList...)).
Msg("Conversion completed with errors")
} else {
log.Debug().

View File

@@ -154,7 +154,7 @@ func TestConverter_ConvertChapter(t *testing.T) {
name: "Tall image without split",
pages: []*manga.Page{createTestPage(t, 1, 800, webpMaxHeight+100, "png")},
split: false,
expectError: false,
expectError: true,
numExpected: 1,
},
}