elie/android-foss
1
0
Fork 0
mirror of https://github.com/offa/android-foss.git synced 2026-07-21 17:35:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: unclosed file handle for readme.md (#620)

Browse Source 
The `README.md` file is opened using `open('README.md', 'r')` but is never explicitly closed. This can lead to resource leaks, especially in long-running processes or if the script were to be extended to open many files. While Python's garbage collector might eventually close it, it's not guaranteed and is considered bad practice.

Affected files: ensure_sorted.py

Signed-off-by: toanmap <174589430+maptoan@users.noreply.github.com>
This commit is contained in:
toanmap
2026-03-30 15:10:40 +00:00
committed by GitHub
parent 0e74d801ba
commit 1fd659ceb1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ensure_sorted.py
+2 -2
View File
@@ -54,10 +54,10 @@ class Category:
return self.__str__() return self.__str__()
def main(): def main():
readme_file = open('README.md', 'r')
# start of the Apps section # start of the Apps section
APPS_LINE_START = '## – Apps –\n' APPS_LINE_START = '## – Apps –\n'
lines = readme_file.readlines() with open('README.md', 'r') as readme_file:
lines = readme_file.readlines()
index: int index: int
try: try: