From a4dc5bdaf5ec7f4d1c49533608b279d7101e23cd Mon Sep 17 00:00:00 2001
From: "thibault.dewailly" <thibault.dewailly@ovh.net>
Date: Tue, 13 Jun 2017 15:36:06 +0200
Subject: [PATCH] No more wildcards in file list to be more resilient

---
 bin/hardening/10.4_default_umask.sh       | 64 +++++++++++++++++++----
 bin/hardening/99.1_timeout_tty.sh         | 62 +++++++++++++++++++---
 bin/hardening/99.2_disable_usb_devices.sh | 64 +++++++++++++++++++----
 3 files changed, 162 insertions(+), 28 deletions(-)

diff --git a/bin/hardening/10.4_default_umask.sh b/bin/hardening/10.4_default_umask.sh
index a7ab7ea..2d999cb 100755
--- a/bin/hardening/10.4_default_umask.sh
+++ b/bin/hardening/10.4_default_umask.sh
@@ -13,29 +13,73 @@ set -u # One variable unset, it's over
 
 USER='root'
 PATTERN='umask 077'
-FILES_TO_SEARCH='/etc/bash.bashrc /etc/profile.d/* /etc/profile'
+FILES_TO_SEARCH='/etc/bash.bashrc /etc/profile.d /etc/profile'
 FILE='/etc/profile.d/CIS_10.4_umask.sh'
 
 # This function will be called if the script status is on enabled / audit mode
 audit () {
-    does_pattern_exist_in_file "$FILES_TO_SEARCH" "^$PATTERN"
-    if [ $FNRET != 0 ]; then
+    SEARCH_RES=0
+    for FILE_SEARCHED in $FILES_TO_SEARCH; do
+        if [ $SEARCH_RES = 1 ]; then break; fi
+        if test -d $FILE_SEARCHED; then
+            debug "$FILE_SEARCHED is a directory"
+            for file_in_dir in $(ls $FILE_SEARCHED); do
+                does_pattern_exist_in_file "$FILE_SEARCHED/$file_in_dir" "^$PATTERN"
+                if [ $FNRET != 0 ]; then
+                    debug "$PATTERN is not present in $FILE_SEARCHED/$file_in_dir"
+                else
+                    ok "$PATTERN is present in $FILE_SEARCHED/$file_in_dir"
+                    SEARCH_RES=1
+                    break
+                fi
+            done
+        else
+            does_pattern_exist_in_file "$FILE_SEARCHED" "^$PATTERN"
+            if [ $FNRET != 0 ]; then
+                debug "$PATTERN is not present in $FILE_SEARCHED"
+            else
+                ok "$PATTERN is present in $FILES_TO_SEARCH"
+                SEARCH_RES=1
+            fi
+        fi
+    done
+    if [ $SEARCH_RES = 0 ]; then
         crit "$PATTERN is not present in $FILES_TO_SEARCH"
-    else
-        ok "$PATTERN is present in $FILES_TO_SEARCH"
     fi
 }
 
 # This function will be called if the script status is on enabled mode
 apply () {
-    does_pattern_exist_in_file "$FILES_TO_SEARCH" "^$PATTERN"
-    if [ $FNRET != 0 ]; then
+    SEARCH_RES=0
+    for FILE_SEARCHED in $FILES_TO_SEARCH; do
+        if [ $SEARCH_RES = 1 ]; then break; fi
+        if test -d $FILE_SEARCHED; then
+            debug "$FILE_SEARCHED is a directory"
+            for file_in_dir in $(ls $FILE_SEARCHED); do
+                does_pattern_exist_in_file "$FILE_SEARCHED/$file_in_dir" "^$PATTERN"
+                if [ $FNRET != 0 ]; then
+                    debug "$PATTERN is not present in $FILE_SEARCHED/$file_in_dir"
+                else
+                    ok "$PATTERN is present in $FILE_SEARCHED/$file_in_dir"
+                    SEARCH_RES=1
+                    break
+                fi
+            done
+        else
+            does_pattern_exist_in_file "$FILE_SEARCHED" "^$PATTERN"
+            if [ $FNRET != 0 ]; then
+                debug "$PATTERN is not present in $FILE_SEARCHED"
+            else
+                ok "$PATTERN is present in $FILES_TO_SEARCH"
+                SEARCH_RES=1
+            fi
+        fi
+    done
+    if [ $SEARCH_RES = 0 ]; then
         warn "$PATTERN is not present in $FILES_TO_SEARCH"
         touch $FILE
         chmod 644 $FILE
         add_end_of_file $FILE "$PATTERN"
-    else
-        ok "$PATTERN is present in $FILES_TO_SEARCH"
     fi
 }
 
@@ -54,7 +98,7 @@ else
         echo "No CIS_ROOT_DIR variable, aborting"
         exit 128
     fi
-fi 
+fi
 
 # Main function, will call the proper functions given the configuration (audit, enabled, disabled)
 if [ -r $CIS_ROOT_DIR/lib/main.sh ]; then
diff --git a/bin/hardening/99.1_timeout_tty.sh b/bin/hardening/99.1_timeout_tty.sh
index dacdfd3..6d8c745 100755
--- a/bin/hardening/99.1_timeout_tty.sh
+++ b/bin/hardening/99.1_timeout_tty.sh
@@ -14,23 +14,69 @@ set -u # One variable unset, it's over
 USER='root'
 PATTERN='TMOUT='
 VALUE='600'
-FILES_TO_SEARCH='/etc/bash.bashrc /etc/profile.d/* /etc/profile'
+FILES_TO_SEARCH='/etc/bash.bashrc /etc/profile.d /etc/profile'
 FILE='/etc/profile.d/CIS_99.1_timeout.sh'
 
 # This function will be called if the script status is on enabled / audit mode
 audit () {
-    does_pattern_exist_in_file "$FILES_TO_SEARCH" "^$PATTERN"
-    if [ $FNRET != 0 ]; then
+    SEARCH_RES=0
+    for FILE_SEARCHED in $FILES_TO_SEARCH; do
+        if [ $SEARCH_RES = 1 ]; then break; fi
+        if test -d $FILE_SEARCHED; then
+            debug "$FILE_SEARCHED is a directory"
+            for file_in_dir in $(ls $FILE_SEARCHED); do
+                does_pattern_exist_in_file "$FILE_SEARCHED/$file_in_dir" "^$PATTERN"
+                if [ $FNRET != 0 ]; then
+                    debug "$PATTERN is not present in $FILE_SEARCHED/$file_in_dir"
+                else
+                    ok "$PATTERN is present in $FILE_SEARCHED/$file_in_dir"
+                    SEARCH_RES=1
+                    break
+                fi
+            done
+        else
+            does_pattern_exist_in_file "$FILE_SEARCHED" "^$PATTERN"
+            if [ $FNRET != 0 ]; then
+                debug "$PATTERN is not present in $FILE_SEARCHED"
+            else
+                ok "$PATTERN is present in $FILES_TO_SEARCH"
+                SEARCH_RES=1
+            fi
+        fi
+    done
+    if [ $SEARCH_RES = 0 ]; then
         crit "$PATTERN is not present in $FILES_TO_SEARCH"
-    else
-        ok "$PATTERN is present in $FILES_TO_SEARCH"
     fi
 }
 
 # This function will be called if the script status is on enabled mode
 apply () {
-    does_pattern_exist_in_file "$FILES_TO_SEARCH" "^$PATTERN"
-    if [ $FNRET != 0 ]; then
+    SEARCH_RES=0
+    for FILE_SEARCHED in $FILES_TO_SEARCH; do
+        if [ $SEARCH_RES = 1 ]; then break; fi
+        if test -d $FILE_SEARCHED; then
+            debug "$FILE_SEARCHED is a directory"
+            for file_in_dir in $(ls $FILE_SEARCHED); do
+                does_pattern_exist_in_file "$FILE_SEARCHED/$file_in_dir" "^$PATTERN"
+                if [ $FNRET != 0 ]; then
+                    debug "$PATTERN is not present in $FILE_SEARCHED/$file_in_dir"
+                else
+                    ok "$PATTERN is present in $FILE_SEARCHED/$file_in_dir"
+                    SEARCH_RES=1
+                    break
+                fi
+            done
+        else
+            does_pattern_exist_in_file "$FILE_SEARCHED" "^$PATTERN"
+            if [ $FNRET != 0 ]; then
+                debug "$PATTERN is not present in $FILE_SEARCHED"
+            else
+                ok "$PATTERN is present in $FILES_TO_SEARCH"
+                SEARCH_RES=1
+            fi
+        fi
+    done
+    if [ $SEARCH_RES = 0 ]; then
         warn "$PATTERN is not present in $FILES_TO_SEARCH"
         touch $FILE
         chmod 644 $FILE
@@ -57,7 +103,7 @@ else
         echo "No CIS_ROOT_DIR variable, aborting"
         exit 128
     fi
-fi 
+fi
 
 # Main function, will call the proper functions given the configuration (audit, enabled, disabled)
 if [ -r $CIS_ROOT_DIR/lib/main.sh ]; then
diff --git a/bin/hardening/99.2_disable_usb_devices.sh b/bin/hardening/99.2_disable_usb_devices.sh
index ca58eab..5b2244e 100755
--- a/bin/hardening/99.2_disable_usb_devices.sh
+++ b/bin/hardening/99.2_disable_usb_devices.sh
@@ -13,23 +13,69 @@ set -u # One variable unset, it's over
 
 USER='root'
 PATTERN='ACTION=="add", SUBSYSTEMS=="usb", TEST=="authorized_default", ATTR{authorized_default}="0"' # We do test disabled by default, whitelist is up to you
-FILES_TO_SEARCH='/etc/udev/rules.d/*'
+FILES_TO_SEARCH='/etc/udev/rules.d'
 FILE='/etc/udev/rules.d/10-CIS_99.2_usb_devices.sh'
 
 # This function will be called if the script status is on enabled / audit mode
 audit () {
-    does_pattern_exist_in_file "$FILES_TO_SEARCH" "^$PATTERN"
-    if [ $FNRET != 0 ]; then
+    SEARCH_RES=0
+    for FILE_SEARCHED in $FILES_TO_SEARCH; do
+        if [ $SEARCH_RES = 1 ]; then break; fi
+        if test -d $FILE_SEARCHED; then
+            debug "$FILE_SEARCHED is a directory"
+            for file_in_dir in $(ls $FILE_SEARCHED); do
+                does_pattern_exist_in_file "$FILE_SEARCHED/$file_in_dir" "^$PATTERN"
+                if [ $FNRET != 0 ]; then
+                    debug "$PATTERN is not present in $FILE_SEARCHED/$file_in_dir"
+                else
+                    ok "$PATTERN is present in $FILE_SEARCHED/$file_in_dir"
+                    SEARCH_RES=1
+                    break
+                fi
+            done
+        else
+            does_pattern_exist_in_file "$FILE_SEARCHED" "^$PATTERN"
+            if [ $FNRET != 0 ]; then
+                debug "$PATTERN is not present in $FILE_SEARCHED"
+            else
+                ok "$PATTERN is present in $FILES_TO_SEARCH"
+                SEARCH_RES=1
+            fi
+        fi
+    done
+    if [ $SEARCH_RES = 0 ]; then
         crit "$PATTERN is not present in $FILES_TO_SEARCH"
-    else
-        ok "$PATTERN is present in $FILES_TO_SEARCH"
     fi
 }
 
 # This function will be called if the script status is on enabled mode
 apply () {
-    does_pattern_exist_in_file "$FILES_TO_SEARCH" "^$PATTERN"
-    if [ $FNRET != 0 ]; then
+    SEARCH_RES=0
+    for FILE_SEARCHED in $FILES_TO_SEARCH; do
+        if [ $SEARCH_RES = 1 ]; then break; fi
+        if test -d $FILE_SEARCHED; then
+            debug "$FILE_SEARCHED is a directory"
+            for file_in_dir in $(ls $FILE_SEARCHED); do
+                does_pattern_exist_in_file "$FILE_SEARCHED/$file_in_dir" "^$PATTERN"
+                if [ $FNRET != 0 ]; then
+                    debug "$PATTERN is not present in $FILE_SEARCHED/$file_in_dir"
+                else
+                    ok "$PATTERN is present in $FILE_SEARCHED/$file_in_dir"
+                    SEARCH_RES=1
+                    break
+                fi
+            done
+        else
+            does_pattern_exist_in_file "$FILE_SEARCHED" "^$PATTERN"
+            if [ $FNRET != 0 ]; then
+                debug "$PATTERN is not present in $FILE_SEARCHED"
+            else
+                ok "$PATTERN is present in $FILES_TO_SEARCH"
+                SEARCH_RES=1
+            fi
+        fi
+    done
+    if [ $SEARCH_RES = 0 ]; then
         warn "$PATTERN is not present in $FILES_TO_SEARCH"
         touch $FILE
         chmod 644 $FILE
@@ -46,8 +92,6 @@ ACTION=="add", ATTR{product}=="*[Kk]eyboard*", TEST=="authorized", ATTR{authoriz
 # PS2-USB converter
 ACTION=="add", ATTR{product}=="*Thinnet TM*", TEST=="authorized", ATTR{authorized}="1"
 '
-    else
-        ok "$PATTERN is present in $FILES_TO_SEARCH"
     fi
 }
 
@@ -66,7 +110,7 @@ else
         echo "No CIS_ROOT_DIR variable, aborting"
         exit 128
     fi
-fi 
+fi
 
 # Main function, will call the proper functions given the configuration (audit, enabled, disabled)
 if [ -r $CIS_ROOT_DIR/lib/main.sh ]; then