13.14_check_duplicate_uid.sh 13.15_check_duplicate_gid.sh^C

bin/hardening/13.11_find_passwd_group_inconsistencies.sh

@@ -21,7 +21,7 @@ audit () {
         debug "Working on group $GROUP"
         if ! grep -q -P "^.*?:[^:]*:$GROUP:" /etc/group; then
             crit "Group $GROUP is referenced by /etc/passwd but does not exist in /etc/group"
-            ERRORS=$(($ERRORS+1))
+            ERRORS=$((ERRORS+1))
         fi
     done
 
@@ -32,17 +32,7 @@ audit () {
 
 # This function will be called if the script status is on enabled mode
 apply () {
-    for GROUP in $(cut -s -d: -f4 /etc/passwd | sort -u ); do
+    info "Solving passwd and group consistency automatically may seriously harm your system, report only here"
-        debug "Working on group $GROUP"
-        if ! grep -q -P "^.*?:[^:]*:$GROUP:" /etc/group; then
-            crit "Group $GROUP is referenced by /etc/passwd but does not exist in /etc/group"
-            ERRORS=$(($ERRORS+1))
-        fi
-    done
-
-    if [ $ERRORS != 0 ]; then
-        warn "Consider creating missing group"
-    fi
 }
 
 # This function will check config parameters required

bin/hardening/13.12_users_valid_homedir.sh

@@ -16,7 +16,12 @@ ERRORS=0
 
 # This function will be called if the script status is on enabled / audit mode
 audit () {
-    cat /etc/passwd | awk -F: '{ print $1 " " $3 " " $6 }' | while read USER USERID DIR; do
+    RESULT=$(cat /etc/passwd | awk -F: '{ print $1 ":" $3 ":" $6 }')
+    for LINE in $RESULT; do 
+        debug "Working on $LINE"
+        USER=$(awk -F: {'print $1'} <<< $LINE)
+        USERID=$(awk -F: {'print $2'} <<< $LINE)
+        DIR=$(awk -F: {'print $3'} <<< $LINE)
         if [ $USERID -ge 1000 -a ! -d "$DIR" -a $USER != "nfsnobody" -a $USER != "nobody" ]; then
             crit "The home directory ($DIR) of user $USER does not exist."
             ERRORS=$((ERRORS+1))    
@@ -30,10 +35,7 @@ audit () {
 
 # This function will be called if the script status is on enabled mode
 apply () {
-    if [ $ERRORS != 0 ]; then
+    info "Modifying home directories may seriously harm your system, report only here"
-        warn "Consider creating missing home directories"
-    fi
-    : 
 }
 
 # This function will check config parameters required

bin/hardening/13.13_check_user_homedir_ownership.sh

@@ -16,13 +16,17 @@ ERRORS=0
 
 # This function will be called if the script status is on enabled / audit mode
 audit () {
-
+    RESULT=$(cat /etc/passwd | awk -F: '{ print $1 ":" $3 ":" $6 }')
-    cat /etc/passwd | awk -F: '{ print $1 " " $3 " " $6 }' | while read USER USERID DIR; do
+    for LINE in $RESULT; do
+        debug "Working on $LINE"
+        USER=$(awk -F: {'print $1'} <<< $LINE)
+        USERID=$(awk -F: {'print $2'} <<< $LINE)
+        DIR=$(awk -F: {'print $3'} <<< $LINE)    
         if [ $USERID -ge 500 -a -d "$DIR" -a $USER != "nfsnobody" ]; then
             OWNER=$(stat -L -c "%U" "$DIR")
             if [ "$OWNER" != "$USER" ]; then
                 crit "The home directory ($DIR) of user $USER is owned by $OWNER."
-                ERRORS=$(($ERRORS+1))
+                ERRORS=$((ERRORS+1))
             fi
         fi
     done

bin/hardening/13.14_check_duplicate_uid.sh

@@ -0,0 +1,58 @@
+#!/bin/bash
+
+#
+# CIS Debian 7 Hardening
+# Authors : Thibault Dewailly, OVH <thibault.dewailly@corp.ovh.com>
+#
+
+#
+# 13.14 Check for Duplicate UIDs (Scored)
+#
+
+set -e # One error, it's over
+set -u # One variable unset, it's over
+
+ERRORS=0
+
+# This function will be called if the script status is on enabled / audit mode
+audit () {
+    RESULT=$(cat /etc/passwd | cut -f3 -d":" | sort -n | uniq -c | awk {'print $1":"$2'} )
+    for LINE in $RESULT; do 
+        debug "Working on line $LINE"
+        OCC_NUMBER=$(awk -F: {'print $1'} <<< $LINE)
+        USERID=$(awk -F: {'print $2'} <<< $LINE) 
+        if [ $OCC_NUMBER -gt 1 ]; then
+            USERS=$(awk -F: '($3 == n) { print $1 }' n=$USERID /etc/passwd | xargs)
+            ERRORS=$((ERRORS+1))
+            crit "Duplicate UID ($USERID): ${USERS}"
+        fi
+    done 
+
+    if [ $ERRORS = 0 ]; then
+        ok "No duplicate UIDs"
+    fi 
+}
+
+# This function will be called if the script status is on enabled mode
+apply () {
+    info "Editing automatically uids may seriously harm your system, report only here"
+}
+
+# This function will check config parameters required
+check_config() {
+    :
+}
+
+# Source Root Dir Parameter
+if [ ! -r /etc/default/cis-hardenning ]; then
+    echo "There is no /etc/default/cis-hardenning FILE, cannot source CIS_ROOT_DIR variable, aborting"
+    exit 128
+else
+    . /etc/default/cis-hardenning
+    if [ -z $CIS_ROOT_DIR ]; then
+        echo "No CIS_ROOT_DIR variable, aborting"
+    fi
+fi 
+
+# Main function, will call the proper functions given the configuration (audit, enabled, disabled)
+[ -r $CIS_ROOT_DIR/lib/main.sh ] && . $CIS_ROOT_DIR/lib/main.sh

bin/hardening/13.15_check_duplicate_gid.sh

@@ -0,0 +1,58 @@
+#!/bin/bash
+
+#
+# CIS Debian 7 Hardening
+# Authors : Thibault Dewailly, OVH <thibault.dewailly@corp.ovh.com>
+#
+
+#
+# 13.15 Check for Duplicate GIDs (Scored)
+#
+
+set -e # One error, it's over
+set -u # One variable unset, it's over
+
+ERRORS=0
+
+# This function will be called if the script status is on enabled / audit mode
+audit () {
+    RESULT=$(cat /etc/group | cut -f3 -d":" | sort -n | uniq -c | awk {'print $1":"$2'} )
+    for LINE in $RESULT; do 
+        debug "Working on line $LINE"
+        OCC_NUMBER=$(awk -F: {'print $1'} <<< $LINE)
+        GROUPID=$(awk -F: {'print $2'} <<< $LINE) 
+        if [ $OCC_NUMBER -gt 1 ]; then
+            USERS=$(awk -F: '($3 == n) { print $1 }' n=$GROUPID /etc/passwd | xargs)
+            ERRORS=$((ERRORS+1))
+            crit "Duplicate UID ($GROUPID): ${USERS}"
+        fi
+    done 
+
+    if [ $ERRORS = 0 ]; then
+        ok "No duplicate GIDss"
+    fi 
+}
+
+# This function will be called if the script status is on enabled mode
+apply () {
+    info "Editing automatically gids may seriously harm your system, report only here"
+}
+
+# This function will check config parameters required
+check_config() {
+    :
+}
+
+# Source Root Dir Parameter
+if [ ! -r /etc/default/cis-hardenning ]; then
+    echo "There is no /etc/default/cis-hardenning FILE, cannot source CIS_ROOT_DIR variable, aborting"
+    exit 128
+else
+    . /etc/default/cis-hardenning
+    if [ -z $CIS_ROOT_DIR ]; then
+        echo "No CIS_ROOT_DIR variable, aborting"
+    fi
+fi 
+
+# Main function, will call the proper functions given the configuration (audit, enabled, disabled)
+[ -r $CIS_ROOT_DIR/lib/main.sh ] && . $CIS_ROOT_DIR/lib/main.sh

etc/conf.d/13.14_check_duplicate_uid.cfg

@@ -0,0 +1,2 @@
+# Configuration for script of same name
+status=enabled

etc/conf.d/13.15_check_duplicate_gid.cfg

@@ -0,0 +1,2 @@
+# Configuration for script of same name
+status=enabled