From cb0f6b63d7811585e33473951262a84c9698d9f6 Mon Sep 17 00:00:00 2001 From: Joe Testa Date: Tue, 12 Mar 2024 20:46:39 -0400 Subject: [PATCH] Fixed new pylint warnings. --- src/ssh_audit/ssh_audit.py | 7 ++----- src/ssh_audit/ssh_socket.py | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/ssh_audit/ssh_audit.py b/src/ssh_audit/ssh_audit.py index fcfd34f..1c82ad6 100755 --- a/src/ssh_audit/ssh_audit.py +++ b/src/ssh_audit/ssh_audit.py @@ -365,11 +365,8 @@ def output_recommendations(out: OutputBuffer, algs: Algorithms, algorithm_recomm for cve_list in VersionVulnerabilityDB.CVE['PuTTY']: vuln_version = float(cve_list[1]) cvssv2_severity = cve_list[4] - - if vuln_version > max_vuln_version: - max_vuln_version = vuln_version - if cvssv2_severity > max_cvssv2_severity: - max_cvssv2_severity = cvssv2_severity + max_vuln_version = max(vuln_version, max_vuln_version) + max_cvssv2_severity = max(cvssv2_severity, max_cvssv2_severity) fn = out.warn if max_cvssv2_severity > 8.0: diff --git a/src/ssh_audit/ssh_socket.py b/src/ssh_audit/ssh_socket.py index 5b8169c..4afaa57 100644 --- a/src/ssh_audit/ssh_socket.py +++ b/src/ssh_audit/ssh_socket.py @@ -246,8 +246,7 @@ class SSH_Socket(ReadBuf, WriteBuf): def send_banner(self, banner: str) -> None: self.send(banner.encode() + b'\r\n') - if self.__state < self.SM_BANNER_SENT: - self.__state = self.SM_BANNER_SENT + self.__state = max(self.__state, self.SM_BANNER_SENT) def ensure_read(self, size: int) -> None: while self.unread_len < size: