mirror of
https://github.com/jtesta/ssh-audit.git
synced 2024-06-30 11:14:45 +02:00
246a41d46f
* Apply Flake8 also on `setup.py` modified: tox.ini * Fix W605 - invalid escape syntax modified: packages/setup.py modified: tox.ini * Update comment about Flake8: W504 W503 and W504 are mutual exclusive - so we have to keep one of them. modified: tox.ini * Fix F841 - variable assigned but never used modified: ssh-audit.py modified: tox.ini * Fix E741 - ambiguous variable name 'l' modified: ssh-audit.py modified: tox.ini * Fix E712 - comparison to False should be 'if cond is False' ... and not 'if conf == False'. modified: ssh-audit.py modified: tox.ini * Fix E711 - comparison to None should be 'if cond is not None' ... and not 'if cond != None'. modified: ssh-audit.py modified: tox.ini * Fix E305 - expected 2 blank lines ... after class or function definition, found 1. modified: ssh-audit.py modified: tox.ini * Fix E303 - too many blank lines modified: ssh-audit.py modified: tox.ini * Fix E303 - too many blank lines modified: ssh-audit.py modified: tox.ini * Fix E301 - expected 1 blank line, found 0 No code change necessary, probably fixed by another commit. modified: tox.ini * Fix E265 - block comment should start with '# ' There is lots of commented out code, which usually should be just deleted. I will keep it for now, as I am not yet very familiar with the code base. modified: ssh-audit.py modified: tox.ini * Fix E261 - at least two spaces before inline comment modified: ssh-audit.py modified: tox.ini * Fix E251 - unexpected spaces around keyword / parameter equals modified: packages/setup.py modified: tox.ini * Fix E231 - missing whitespace after ',' No code change necessary, probably fixed by previous commit. modified: tox.ini * Fix E226 - missing whitespace around arithmetic operator modified: ssh-audit.py modified: tox.ini * Fix W293 - blank line contains whitespace modified: ssh-audit.py modified: tox.ini * Fix E221 - multiple spaces before operator modified: ssh-audit.py modified: tox.ini * Update comment about Flake 8 E241 Lots of data is formatted as tables, so this warning is disabled for a good reason. modified: tox.ini * Fix E401 - multiple imports on one line modified: ssh-audit.py modified: tox.ini * Do not ignore Flake8 warning F401 ... as there were no errors in source code anyway. modified: tox.ini * Fix F821 - undefined name modified: ssh-audit.py modified: tox.ini * Reformat ignore section for Flake8 modified: tox.ini * Flake8 test suite modified: test/conftest.py modified: test/test_auditconf.py modified: test/test_banner.py modified: test/test_buffer.py modified: test/test_errors.py modified: test/test_output.py modified: test/test_resolve.py modified: test/test_socket.py modified: test/test_software.py modified: test/test_ssh1.py modified: test/test_ssh2.py modified: test/test_ssh_algorithm.py modified: test/test_utils.py modified: test/test_version_compare.py modified: tox.ini
201 lines
6.0 KiB
Python
201 lines
6.0 KiB
Python
#!/usr/bin/env python
|
|
# -*- coding: utf-8 -*-
|
|
import pytest
|
|
|
|
|
|
# pylint: disable=attribute-defined-outside-init
|
|
class TestAuditConf(object):
|
|
@pytest.fixture(autouse=True)
|
|
def init(self, ssh_audit):
|
|
self.AuditConf = ssh_audit.AuditConf
|
|
self.usage = ssh_audit.usage
|
|
|
|
@staticmethod
|
|
def _test_conf(conf, **kwargs):
|
|
options = {
|
|
'host': None,
|
|
'port': 22,
|
|
'ssh1': True,
|
|
'ssh2': True,
|
|
'batch': False,
|
|
'colors': True,
|
|
'verbose': False,
|
|
'level': 'info',
|
|
'ipv4': True,
|
|
'ipv6': True,
|
|
'ipvo': ()
|
|
}
|
|
for k, v in kwargs.items():
|
|
options[k] = v
|
|
assert conf.host == options['host']
|
|
assert conf.port == options['port']
|
|
assert conf.ssh1 is options['ssh1']
|
|
assert conf.ssh2 is options['ssh2']
|
|
assert conf.batch is options['batch']
|
|
assert conf.colors is options['colors']
|
|
assert conf.verbose is options['verbose']
|
|
assert conf.level == options['level']
|
|
assert conf.ipv4 == options['ipv4']
|
|
assert conf.ipv6 == options['ipv6']
|
|
assert conf.ipvo == options['ipvo']
|
|
|
|
def test_audit_conf_defaults(self):
|
|
conf = self.AuditConf()
|
|
self._test_conf(conf)
|
|
|
|
def test_audit_conf_booleans(self):
|
|
conf = self.AuditConf()
|
|
for p in ['ssh1', 'ssh2', 'batch', 'colors', 'verbose']:
|
|
for v in [True, 1]:
|
|
setattr(conf, p, v)
|
|
assert getattr(conf, p) is True
|
|
for v in [False, 0]:
|
|
setattr(conf, p, v)
|
|
assert getattr(conf, p) is False
|
|
|
|
def test_audit_conf_port(self):
|
|
conf = self.AuditConf()
|
|
for port in [22, 2222]:
|
|
conf.port = port
|
|
assert conf.port == port
|
|
for port in [-1, 0, 65536, 99999]:
|
|
with pytest.raises(ValueError) as excinfo:
|
|
conf.port = port
|
|
excinfo.match(r'.*invalid port.*')
|
|
|
|
def test_audit_conf_ipvo(self):
|
|
# ipv4-only
|
|
conf = self.AuditConf()
|
|
conf.ipv4 = True
|
|
assert conf.ipv4 is True
|
|
assert conf.ipv6 is False
|
|
assert conf.ipvo == (4,)
|
|
# ipv6-only
|
|
conf = self.AuditConf()
|
|
conf.ipv6 = True
|
|
assert conf.ipv4 is False
|
|
assert conf.ipv6 is True
|
|
assert conf.ipvo == (6,)
|
|
# ipv4-only (by removing ipv6)
|
|
conf = self.AuditConf()
|
|
conf.ipv6 = False
|
|
assert conf.ipv4 is True
|
|
assert conf.ipv6 is False
|
|
assert conf.ipvo == (4, )
|
|
# ipv6-only (by removing ipv4)
|
|
conf = self.AuditConf()
|
|
conf.ipv4 = False
|
|
assert conf.ipv4 is False
|
|
assert conf.ipv6 is True
|
|
assert conf.ipvo == (6, )
|
|
# ipv4-preferred
|
|
conf = self.AuditConf()
|
|
conf.ipv4 = True
|
|
conf.ipv6 = True
|
|
assert conf.ipv4 is True
|
|
assert conf.ipv6 is True
|
|
assert conf.ipvo == (4, 6)
|
|
# ipv6-preferred
|
|
conf = self.AuditConf()
|
|
conf.ipv6 = True
|
|
conf.ipv4 = True
|
|
assert conf.ipv4 is True
|
|
assert conf.ipv6 is True
|
|
assert conf.ipvo == (6, 4)
|
|
# ipvo empty
|
|
conf = self.AuditConf()
|
|
conf.ipvo = ()
|
|
assert conf.ipv4 is True
|
|
assert conf.ipv6 is True
|
|
assert conf.ipvo == ()
|
|
# ipvo validation
|
|
conf = self.AuditConf()
|
|
conf.ipvo = (1, 2, 3, 4, 5, 6)
|
|
assert conf.ipvo == (4, 6)
|
|
conf.ipvo = (4, 4, 4, 6, 6)
|
|
assert conf.ipvo == (4, 6)
|
|
|
|
def test_audit_conf_level(self):
|
|
conf = self.AuditConf()
|
|
for level in ['info', 'warn', 'fail']:
|
|
conf.level = level
|
|
assert conf.level == level
|
|
for level in ['head', 'good', 'unknown', None]:
|
|
with pytest.raises(ValueError) as excinfo:
|
|
conf.level = level
|
|
excinfo.match(r'.*invalid level.*')
|
|
|
|
def test_audit_conf_cmdline(self):
|
|
# pylint: disable=too-many-statements
|
|
c = lambda x: self.AuditConf.from_cmdline(x.split(), self.usage) # noqa
|
|
with pytest.raises(SystemExit):
|
|
conf = c('')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('-x')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('-h')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('--help')
|
|
with pytest.raises(SystemExit):
|
|
conf = c(':')
|
|
with pytest.raises(SystemExit):
|
|
conf = c(':22')
|
|
conf = c('localhost')
|
|
self._test_conf(conf, host='localhost')
|
|
conf = c('github.com')
|
|
self._test_conf(conf, host='github.com')
|
|
conf = c('localhost:2222')
|
|
self._test_conf(conf, host='localhost', port=2222)
|
|
conf = c('-p 2222 localhost')
|
|
self._test_conf(conf, host='localhost', port=2222)
|
|
conf = c('2001:4860:4860::8888')
|
|
self._test_conf(conf, host='2001:4860:4860::8888')
|
|
conf = c('[2001:4860:4860::8888]:22')
|
|
self._test_conf(conf, host='2001:4860:4860::8888')
|
|
conf = c('[2001:4860:4860::8888]:2222')
|
|
self._test_conf(conf, host='2001:4860:4860::8888', port=2222)
|
|
conf = c('-p 2222 2001:4860:4860::8888')
|
|
self._test_conf(conf, host='2001:4860:4860::8888', port=2222)
|
|
with pytest.raises(SystemExit):
|
|
conf = c('localhost:')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('localhost:abc')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('-p abc localhost')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('localhost:-22')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('-p -22 localhost')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('localhost:99999')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('-p 99999 localhost')
|
|
conf = c('-1 localhost')
|
|
self._test_conf(conf, host='localhost', ssh1=True, ssh2=False)
|
|
conf = c('-2 localhost')
|
|
self._test_conf(conf, host='localhost', ssh1=False, ssh2=True)
|
|
conf = c('-12 localhost')
|
|
self._test_conf(conf, host='localhost', ssh1=True, ssh2=True)
|
|
conf = c('-4 localhost')
|
|
self._test_conf(conf, host='localhost', ipv4=True, ipv6=False, ipvo=(4,))
|
|
conf = c('-6 localhost')
|
|
self._test_conf(conf, host='localhost', ipv4=False, ipv6=True, ipvo=(6,))
|
|
conf = c('-46 localhost')
|
|
self._test_conf(conf, host='localhost', ipv4=True, ipv6=True, ipvo=(4, 6))
|
|
conf = c('-64 localhost')
|
|
self._test_conf(conf, host='localhost', ipv4=True, ipv6=True, ipvo=(6, 4))
|
|
conf = c('-b localhost')
|
|
self._test_conf(conf, host='localhost', batch=True, verbose=True)
|
|
conf = c('-n localhost')
|
|
self._test_conf(conf, host='localhost', colors=False)
|
|
conf = c('-v localhost')
|
|
self._test_conf(conf, host='localhost', verbose=True)
|
|
conf = c('-l info localhost')
|
|
self._test_conf(conf, host='localhost', level='info')
|
|
conf = c('-l warn localhost')
|
|
self._test_conf(conf, host='localhost', level='warn')
|
|
conf = c('-l fail localhost')
|
|
self._test_conf(conf, host='localhost', level='fail')
|
|
with pytest.raises(SystemExit):
|
|
conf = c('-l something localhost')
|