mirror of
https://github.com/jtesta/ssh-audit.git
synced 2024-06-30 11:14:45 +02:00
246a41d46f
* Apply Flake8 also on `setup.py` modified: tox.ini * Fix W605 - invalid escape syntax modified: packages/setup.py modified: tox.ini * Update comment about Flake8: W504 W503 and W504 are mutual exclusive - so we have to keep one of them. modified: tox.ini * Fix F841 - variable assigned but never used modified: ssh-audit.py modified: tox.ini * Fix E741 - ambiguous variable name 'l' modified: ssh-audit.py modified: tox.ini * Fix E712 - comparison to False should be 'if cond is False' ... and not 'if conf == False'. modified: ssh-audit.py modified: tox.ini * Fix E711 - comparison to None should be 'if cond is not None' ... and not 'if cond != None'. modified: ssh-audit.py modified: tox.ini * Fix E305 - expected 2 blank lines ... after class or function definition, found 1. modified: ssh-audit.py modified: tox.ini * Fix E303 - too many blank lines modified: ssh-audit.py modified: tox.ini * Fix E303 - too many blank lines modified: ssh-audit.py modified: tox.ini * Fix E301 - expected 1 blank line, found 0 No code change necessary, probably fixed by another commit. modified: tox.ini * Fix E265 - block comment should start with '# ' There is lots of commented out code, which usually should be just deleted. I will keep it for now, as I am not yet very familiar with the code base. modified: ssh-audit.py modified: tox.ini * Fix E261 - at least two spaces before inline comment modified: ssh-audit.py modified: tox.ini * Fix E251 - unexpected spaces around keyword / parameter equals modified: packages/setup.py modified: tox.ini * Fix E231 - missing whitespace after ',' No code change necessary, probably fixed by previous commit. modified: tox.ini * Fix E226 - missing whitespace around arithmetic operator modified: ssh-audit.py modified: tox.ini * Fix W293 - blank line contains whitespace modified: ssh-audit.py modified: tox.ini * Fix E221 - multiple spaces before operator modified: ssh-audit.py modified: tox.ini * Update comment about Flake 8 E241 Lots of data is formatted as tables, so this warning is disabled for a good reason. modified: tox.ini * Fix E401 - multiple imports on one line modified: ssh-audit.py modified: tox.ini * Do not ignore Flake8 warning F401 ... as there were no errors in source code anyway. modified: tox.ini * Fix F821 - undefined name modified: ssh-audit.py modified: tox.ini * Reformat ignore section for Flake8 modified: tox.ini * Flake8 test suite modified: test/conftest.py modified: test/test_auditconf.py modified: test/test_banner.py modified: test/test_buffer.py modified: test/test_errors.py modified: test/test_output.py modified: test/test_resolve.py modified: test/test_socket.py modified: test/test_software.py modified: test/test_ssh1.py modified: test/test_ssh2.py modified: test/test_ssh_algorithm.py modified: test/test_utils.py modified: test/test_version_compare.py modified: tox.ini
70 lines
3.0 KiB
Python
70 lines
3.0 KiB
Python
#!/usr/bin/env python
|
|
# -*- coding: utf-8 -*-
|
|
import pytest
|
|
|
|
|
|
# pylint: disable=line-too-long,attribute-defined-outside-init
|
|
class TestBanner(object):
|
|
@pytest.fixture(autouse=True)
|
|
def init(self, ssh_audit):
|
|
self.ssh = ssh_audit.SSH
|
|
|
|
def test_simple_banners(self):
|
|
banner = lambda x: self.ssh.Banner.parse(x) # noqa
|
|
b = banner('SSH-2.0-OpenSSH_7.3')
|
|
assert b.protocol == (2, 0)
|
|
assert b.software == 'OpenSSH_7.3'
|
|
assert b.comments is None
|
|
assert str(b) == 'SSH-2.0-OpenSSH_7.3'
|
|
b = banner('SSH-1.99-Sun_SSH_1.1.3')
|
|
assert b.protocol == (1, 99)
|
|
assert b.software == 'Sun_SSH_1.1.3'
|
|
assert b.comments is None
|
|
assert str(b) == 'SSH-1.99-Sun_SSH_1.1.3'
|
|
b = banner('SSH-1.5-Cisco-1.25')
|
|
assert b.protocol == (1, 5)
|
|
assert b.software == 'Cisco-1.25'
|
|
assert b.comments is None
|
|
assert str(b) == 'SSH-1.5-Cisco-1.25'
|
|
|
|
def test_invalid_banners(self):
|
|
b = lambda x: self.ssh.Banner.parse(x) # noqa
|
|
assert b('Something') is None
|
|
assert b('SSH-XXX-OpenSSH_7.3') is None
|
|
|
|
def test_banners_with_spaces(self):
|
|
b = lambda x: self.ssh.Banner.parse(x) # noqa
|
|
s = 'SSH-2.0-OpenSSH_4.3p2'
|
|
assert str(b('SSH-2.0-OpenSSH_4.3p2 ')) == s
|
|
assert str(b('SSH-2.0- OpenSSH_4.3p2')) == s
|
|
assert str(b('SSH-2.0- OpenSSH_4.3p2 ')) == s
|
|
s = 'SSH-2.0-OpenSSH_4.3p2 Debian-9etch3 on i686-pc-linux-gnu'
|
|
assert str(b('SSH-2.0- OpenSSH_4.3p2 Debian-9etch3 on i686-pc-linux-gnu')) == s
|
|
assert str(b('SSH-2.0-OpenSSH_4.3p2 Debian-9etch3 on i686-pc-linux-gnu ')) == s
|
|
assert str(b('SSH-2.0- OpenSSH_4.3p2 Debian-9etch3 on i686-pc-linux-gnu ')) == s
|
|
|
|
def test_banners_without_software(self):
|
|
b = lambda x: self.ssh.Banner.parse(x) # noqa
|
|
assert b('SSH-2.0').protocol == (2, 0)
|
|
assert b('SSH-2.0').software is None
|
|
assert b('SSH-2.0').comments is None
|
|
assert str(b('SSH-2.0')) == 'SSH-2.0'
|
|
assert b('SSH-2.0-').protocol == (2, 0)
|
|
assert b('SSH-2.0-').software == ''
|
|
assert b('SSH-2.0-').comments is None
|
|
assert str(b('SSH-2.0-')) == 'SSH-2.0-'
|
|
|
|
def test_banners_with_comments(self):
|
|
b = lambda x: self.ssh.Banner.parse(x) # noqa
|
|
assert repr(b('SSH-2.0-OpenSSH_7.2p2 Ubuntu-1')) == '<Banner(protocol=2.0, software=OpenSSH_7.2p2, comments=Ubuntu-1)>'
|
|
assert repr(b('SSH-1.99-OpenSSH_3.4p1 Debian 1:3.4p1-1.woody.3')) == '<Banner(protocol=1.99, software=OpenSSH_3.4p1, comments=Debian 1:3.4p1-1.woody.3)>'
|
|
assert repr(b('SSH-1.5-1.3.7 F-SECURE SSH')) == '<Banner(protocol=1.5, software=1.3.7, comments=F-SECURE SSH)>'
|
|
|
|
def test_banners_with_multiple_protocols(self):
|
|
b = lambda x: self.ssh.Banner.parse(x) # noqa
|
|
assert str(b('SSH-1.99-SSH-1.99-OpenSSH_3.6.1p2')) == 'SSH-1.99-OpenSSH_3.6.1p2'
|
|
assert str(b('SSH-2.0-SSH-2.0-OpenSSH_4.3p2 Debian-9')) == 'SSH-2.0-OpenSSH_4.3p2 Debian-9'
|
|
assert str(b('SSH-1.99-SSH-2.0-dropbear_0.5')) == 'SSH-1.99-dropbear_0.5'
|
|
assert str(b('SSH-2.0-SSH-1.99-OpenSSH_4.2p1 SSH Secure Shell (non-commercial)')) == 'SSH-1.99-OpenSSH_4.2p1 SSH Secure Shell (non-commercial)'
|
|
assert str(b('SSH-1.99-SSH-1.99-SSH-1.99-OpenSSH_3.9p1')) == 'SSH-1.99-OpenSSH_3.9p1'
|