clean code

README.md

@@ -1,92 +1,66 @@
 # Super-Vision
 
-
-
-## Getting started
-
-To make it easy for you to get started with GitLab, here's a list of recommended next steps.
-
-Already a pro? Just edit this README.md and make it your own. Want to make it easy? [Use the template at the bottom](#editing-this-readme)!
-
-## Add your files
-
-- [ ] [Create](https://docs.gitlab.com/ee/user/project/repository/web_editor.html#create-a-file) or [upload](https://docs.gitlab.com/ee/user/project/repository/web_editor.html#upload-a-file) files
-- [ ] [Add files using the command line](https://docs.gitlab.com/ee/gitlab-basics/add-file.html#add-a-file-using-the-command-line) or push an existing Git repository with the following command:
-
-```
-cd existing_repo
-git remote add origin https://gitlab.outscale.internal/kevin.francoise/super-vision.git
-git branch -M main
-git push -uf origin main
-```
-
-## Integrate with your tools
-
-- [ ] [Set up project integrations](https://gitlab.outscale.internal/kevin.francoise/super-vision/-/settings/integrations)
-
-## Collaborate with your team
-
-- [ ] [Invite team members and collaborators](https://docs.gitlab.com/ee/user/project/members/)
-- [ ] [Create a new merge request](https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html)
-- [ ] [Automatically close issues from merge requests](https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically)
-- [ ] [Enable merge request approvals](https://docs.gitlab.com/ee/user/project/merge_requests/approvals/)
-- [ ] [Automatically merge when pipeline succeeds](https://docs.gitlab.com/ee/user/project/merge_requests/merge_when_pipeline_succeeds.html)
-
-## Test and Deploy
-
-Use the built-in continuous integration in GitLab.
-
-- [ ] [Get started with GitLab CI/CD](https://docs.gitlab.com/ee/ci/quick_start/index.html)
-- [ ] [Analyze your code for known vulnerabilities with Static Application Security Testing(SAST)](https://docs.gitlab.com/ee/user/application_security/sast/)
-- [ ] [Deploy to Kubernetes, Amazon EC2, or Amazon ECS using Auto Deploy](https://docs.gitlab.com/ee/topics/autodevops/requirements.html)
-- [ ] [Use pull-based deployments for improved Kubernetes management](https://docs.gitlab.com/ee/user/clusters/agent/)
-- [ ] [Set up protected environments](https://docs.gitlab.com/ee/ci/environments/protected_environments.html)
-
-***
-
-# Editing this README
-
-When you're ready to make this README your own, just edit this file and use the handy template below (or feel free to structure it however you want - this is just a starting point!). Thank you to [makeareadme.com](https://www.makeareadme.com/) for this template.
-
-## Suggestions for a good README
-Every project is different, so consider which of these sections apply to yours. The sections used in the template are suggestions for most open source projects. Also keep in mind that while a README can be too long and detailed, too long is better than too short. If you think your README is too long, consider utilizing another form of documentation rather than cutting out information.
-
-## Name
-Choose a self-explaining name for your project.
-
 ## Description
-Let people know what your project can do specifically. Provide context and add a link to any reference visitors might be unfamiliar with. A list of Features or a Background subsection can also be added here. If there are alternatives to your project, this is a good place to list differentiating factors.
-
-## Badges
-On some READMEs, you may see small images that convey metadata, such as whether or not all the tests are passing for the project. You can use Shields to add some to your README. Many services also have instructions for adding a badge.
-
-## Visuals
-Depending on what you are making, it can be a good idea to include screenshots or even a video (you'll frequently see GIFs rather than actual videos). Tools like ttygif can help, but check out Asciinema for a more sophisticated method.
+Super-Vision is a monitoring dashboard for Zabbix.
 
 ## Installation
-Within a particular ecosystem, there may be a common way of installing things, such as using Yarn, NuGet, or Homebrew. However, consider the possibility that whoever is reading your README is a novice and would like more guidance. Listing specific steps helps remove ambiguity and gets people to using your project as quickly as possible. If it only runs in a specific context like a particular programming language version or operating system or has dependencies that have to be installed manually, also add a Requirements subsection.
+You will need [Python 3.6+](https://www.python.org/) or later.
+It is a good practice to create a dedicated virtualenv first. Even if it usually won't harm to install Python libraries directly on the system, better to contain dependencies in a virtual environment.
+
+- Clone this repository
+- Change directory
+`cd super-vision`
+- Create a virtualenv
+```
+python3 -m venv .venv
+source .venv/bin/activate
+```
+- Install Python packages
+```
+pip3 install -r requirements.txt
+```
 
 ## Usage
-Use examples liberally, and show the expected output if you can. It's helpful to have inline the smallest example of usage that you can demonstrate, while providing links to more sophisticated examples if they are too long to reasonably include in the README.
+```
+Usage: super-server.py [-h] 
+	--zabbix_ip ZABBIX_IP 
+	--zabbix_url ZABBIX_URL 
+	--alert_limit ALERT_LIMIT 
+	--zabbix_hostgroup ZABBIX_HOSTGROUP 
+	--zabbix_min_severity ZABBIX_MIN_SEVERITY
+	--zabbix_login ZABBIX_LOGIN 
+	--zabbix_pass ZABBIX_PASS 
+	--list_zabbix_servers LIST_ZABBIX_SERVERS [LIST_ZABBIX_SERVERS ...] 
+	--zabbix_timeout ZABBIX_TIMEOUT
+	--port PORT
+```
 
-## Support
-Tell people where they can go to for help. It can be any combination of an issue tracker, a chat room, an email address, etc.
+| Argument | Description | Example |
+| ----------- | ----------- | ----------- |
+| zabbix_ip | IP/URL of the Zabbix Frontend. | 127.0.0.1:8080 |
+| zabbix_url | IP/URL of the Zabbix Frontend. Used to create triggers URL. | https://zabbix.internal
+| alert_limit | Number of alerts to retrieve for all hostgroups. | 2000 |
+| zabbix_hostgroup | Hostgroup or Pattern | Team-* |
+| zabbix_min_severity | Minimum severity to retrieve. | 3 |
+| zabbix_login | Login to connect to Zabbix API. | Admin |
+| zabbix_pass | Password to connect to Zabbix API. | admin |
+| list_zabbix_servers | List of Zabbix server IP to check if they are running or no and display an alert on the dashboard. | 127.0.0.1:10051 |
+| zabbix_timeout | Timeout call to the Zabbix API. | 30 |
+| port | Listen server port. | 80 |
 
-## Roadmap
-If you have ideas for releases in the future, it is a good idea to list them in the README.
+## Examples
+
+```
+python3 super-server.py --zabbix_ip=127.0.0.1:8080 --zabbix_url='https://zabbix.internal' --alert_limit=100 --zabbix_hostgroup="Team-*" --zabbix_min_severity=3 --zabbix_login=Admin --zabbix_pass='admin' --list_zabbix_servers=127.0.0.1:10051 --zabbix_timeout=30 --port=8080
+```
 
 ## Contributing
-State if you are open to contributions and what your requirements are for accepting them.
-
-For people who want to make changes to your project, it's helpful to have some documentation on how to get started. Perhaps there is a script that they should run or some environment variables that they need to set. Make these steps explicit. These instructions could also be useful to your future self.
-
-You can also document commands to lint the code or run tests. These steps help to ensure high code quality and reduce the likelihood that the changes inadvertently break something. Having instructions for running tests is especially helpful if it requires external setup, such as starting a Selenium server for testing in a browser.
-
-## Authors and acknowledgment
-Show your appreciation to those who have contributed to the project.
+- If you think you've found a bug in the code or you have a question regarding the usage of this software, please reach out to us by opening an issue in this GitHub repository.
+- Contributions to this project are welcome: if you want to add a feature or a fix a bug, please do so by opening a Pull Request in this GitHub repository. In case of feature contribution, we kindly ask you to open an issue to discuss it beforehand.
 
 ## License
-For open source projects, say how it is licensed.
+> Copyright Outscale SAS
+>
+> BSD-3-Clause
 
-## Project status
-If you have run out of energy or time for your project, put a note at the top of the README saying that development has slowed down or stopped completely. Someone may choose to fork your project or volunteer to step in as a maintainer or owner, allowing your project to keep going. You can also make an explicit request for maintainers.
+This project is compliant with [REUSE](https://reuse.software/).

config.py

@@ -1,5 +1,6 @@
 
 CONTENT = {}
+
 LIST_SEVERITY = {
 '0': 'Not classified',
 '1': 'Information',
@@ -8,6 +9,7 @@ LIST_SEVERITY = {
 '4': 'High',
 '5': 'Disaster'
 }
+
 TOTAL_ALERTS = "0"
 
 TEMPLATE_HEAD = '''<!doctype html>
@@ -150,23 +152,9 @@ TEMPLATE_FOOTER='''
 '''
 
 COLOR_TEAM = {
-	"Team-mon":						"#04B404;",
-	"Team-Infra":						"#0000FF;",
-	"Team-sys":						"#FF0000;",
-	"Team-datalake":					"#FFBF00;",
-	"Team-inge":						"#088A4B;",
-	"Team-CI":						"#AEB404;",
-	"Team-QA":						"#FF00FF;",
-	"Team-IT":						"#006666;",
-	"Team-top":						"#1DD8EA;",
-	"Team-RD":						"#FE9A2E;",
-	"Team-sec1":						"#0B6138;",
-	"Team-nocall":						"#AC58FA;",
-	"Team-nprd":						"#0B610B;",
-	"Team-exa":						"#E7B339;",
-	"Team-LM":						"#DD90F2;",
-	"Team-secu":						"#F290E8;",
-	"No-group":						"#BDBDBD;"
+	"Discovered hosts":					"#04B404;",
+	"Linux servers":					"#DD90F2;",
+	"Zabbix servers":					"#F290E8;"
 }
 
 NAVBAR = '''

data/motd.json

@@ -0,0 +1 @@
+{}

data/zabbix-servers.json

@@ -0,0 +1 @@
+{"172.24.10.111": 0}

super-server.py

@@ -27,7 +27,7 @@ _logger.setLevel(logging.DEBUG)
 
 parser = argparse.ArgumentParser()
 parser.add_argument("--zabbix_ip", help="Zabbix Frontend IP.", required=True)
-parser.add_argument("--zabbix_url", help="Zabbix URL.", required=True)
+parser.add_argument("--zabbix_url", help="Zabbix URL. Used to build triggers URL.", required=True)
 parser.add_argument("--alert_limit", help="Number of alerts to retrieve.", required=True)
 parser.add_argument("--zabbix_hostgroup", help="Search for hostgroups which correspond to this parameter (Wildcard allowed).", required=True)
 parser.add_argument("--zabbix_min_severity", help="Minimum trigger severity to retrieve.", required=True)
@@ -80,6 +80,11 @@ def convert_seconds(seconds):
 			time = "a month"
 		else:
 			time = str(round(seconds / 2629746)) + " months"
+	if seconds >= 31536000:
+		if round(seconds / 31536000) == 1:
+			time = "a year"
+		else:
+			time = str(round(seconds / 31536000)) + " years"
 	return time
 
 def severity_badge(severity):
@@ -161,12 +166,12 @@ async def check_servers():
 				_logger.error("[ERR] - Port {} KO: {}".format(port, ip))
 			j[ip] = result
 			sock.close()
-		if os.path.exists('/data/zabbix-servers.json'):
-			out = read_file('/data/zabbix-servers.json')
+		if os.path.exists('./data/zabbix-servers.json'):
+			out = read_file('./data/zabbix-servers.json')
 			out.update(j)
-			write_file(out, '/data/zabbix-servers.json')
+			write_file(out, './data/zabbix-servers.json')
 		else:
-			write_file(j, '/data/zabbix-servers.json')
+			write_file(j, './data/zabbix-servers.json')
 		await asyncio.sleep(60)
 
 async def post_note(request):
@@ -187,12 +192,12 @@ async def post_note(request):
 		'lvl': lvl
 	})
 
-	if os.path.exists('/data/motd.json'):
-		out = read_file('/data/motd.json')
+	if os.path.exists('./data/motd.json'):
+		out = read_file('./data/motd.json')
 		out.update(j)
-		write_file(out, '/data/motd.json')
+		write_file(out, './data/motd.json')
 	else:
-		write_file(j, '/data/motd.json')
+		write_file(j, './data/motd.json')
 	_logger.info("[ADD] - {}".format(j))
 	return aiohttp.web.HTTPFound(location=url, text='{}'.format(ts), content_type='text/html')
 
@@ -213,10 +218,10 @@ async def del_note(request):
 	data = await request.post()
 	note_id = data['note_id']
 	url = data['url']
-	out = read_file('/data/motd.json')
+	out = read_file('./data/motd.json')
 	_logger.info('[DEL] - {}'.format(out[note_id]))
 	del out[note_id]
-	write_file(out, '/data/motd.json')
+	write_file(out, './data/motd.json')
 	return aiohttp.web.HTTPFound(location=url)
 
 async def show_alerts(request):
@@ -246,7 +251,7 @@ async def show_alerts(request):
 	teams = request.match_info.get('teams')
 	if not teams:
 		teams = []
-	notes = read_file('/data/motd.json')
+	notes = read_file('./data/motd.json')
 	if notes:
 		for ts in notes:
 			for note in notes[ts]:
@@ -254,18 +259,13 @@ async def show_alerts(request):
 					date_note = datetime.datetime.utcfromtimestamp(int(ts)).strftime('%Y-%m-%d %H:%M:%S')
 					html_notes += "<tr class='bg-"+note['lvl']+"'><td class='text-left'><span class='octicon octicon-clock'></span> "+date_note+"</td><td class='text-center'> "+note['msg']+"</td><td class='text-right'><span class='octicon octicon-hubot'></span><i> (by "+note['name']+")</i></td><td class='text-right'><form action='/del' method='post' accept-charset='utf-8' enctype='application/x-www-form-urlencoded'><input type='text' class='form-control url_note' name='url' hidden readonly><input type='text' name='note_id' value='"+ts+"' readonly hidden><button type='submit' class='btn btn-outline-light btn-sm' id='del_note' ><span class='octicon octicon-trashcan'></span></button></form></td></tr>"
 	html_notes += '</table>'
-	check_zbx = read_file('/data/zabbix-servers.json')
+	check_zbx = read_file('./data/zabbix-servers.json')
 	if check_zbx:
 		for ip in check_zbx:
 			if check_zbx[ip] != 0:
 				html_check += "<tr class='bg-danger'><td class='text-center align-left'><span class='octicon octicon-alert'></span> Zabbix Server: "+ ip + " seems UNREACHABLE! <span class='octicon octicon-alert'></span></td></tr>"
 	html_check += '</table>'
-	### EASTER EGG ###
-	if teams != 'Team-sys':
-		IMAGE='<div class="container-fluid image-container"><img src="/images/logo.png" width="50%"/></div>'
-	else:
-		IMAGE='<div class="container-fluid image-mexico"><img src="/images/patate.jpg" width="30%"/></div>'
-	##################
+	IMAGE='<div class="container-fluid image-container"><img src="/images/zabbix_logo_500x131.png" width="30%"/></div>'
 	if teams:
 		team_list = teams.split('+')
 		for team in team_list:
@@ -405,9 +405,9 @@ def main():
 		aiohttp.web.post('/del', del_note),
 		aiohttp.web.get('/{teams}', show_alerts),
 		aiohttp.web.get('/tv/{teams}', show_alerts),
-		aiohttp.web.static('/images', '/images'),
-		aiohttp.web.static('/css', '/css'),
-		aiohttp.web.static('/js', '/js')])
+		aiohttp.web.static('/images', 'images'),
+		aiohttp.web.static('/css', 'css'),
+		aiohttp.web.static('/js', 'js')])
 
 
 	app.on_startup.append(start_background_tasks)